Repository navigation
fix(night-duty): simplify the iCal token lookup (SonarCloud S3267) - #81
Merged
Merged
Conversation
…kip-docs] NightFeed.FindMatchingToken now uses FirstOrDefault instead of a foreach loop; the per-candidate FixedTimeEquals comparison is unchanged. The remaining SonarCloud findings on PR #77 (S3903, S1186, S3060 on the union declaration, S8970, S107 on the feed handler) are known false positives (sonar-known-issues.md) and are left for marking in SonarCloud. Refs #67 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
|
Backend coverage
Full report: the coverage artifact of this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #77: the SonarCloud fix that wasn't in it when it was merged.
NightFeed.FindMatchingTokenusesFirstOrDefaultinstead of aforeachloop (SonarCloudS3267). Each candidate is still compared withCryptographicOperations.FixedTimeEquals, so the behaviour is the same.The other SonarCloud findings from #77 are known false positives (see
.claude/skills/claude-backend/references/sonar-known-issues.md) and should be marked in SonarCloud rather than changed in code:S3903×3,S1186,S3060on theNightFeedEventunion: Sonar can't parse the previewunionsyntax.S8970inNightIcalFeedWriter: nullable is enabled project-wide, but automatic analysis doesn't see it.S107onGetNightIcalFeedHandler.Handle: the handler takes its injected dependencies as parameters.Testing
dotnet test src/backend/backend.slnx --filter "FullyQualifiedName~NightIcal|FullyQualifiedName~NightFeed": 23 passed.Refs #67
🤖 Generated with Claude Code